[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Difference between AR code for sv and v


Hi,

can someone enlighten me, why is the code for adding an Authentication-Results header different for the 'mode sv' and the 'mode v' situation? For 'sv' I see (openarc.c starting at line 3429 and specifically line 3574 onwards):

        /* append our chain status if verifying */
        if (BITSET(ARC_MODE_VERIFY, cc->cctx_mode))
        {
            if (arcf_dstring_len(afc->mctx_tmpstr) > 0)
                arcf_dstring_cat(afc->mctx_tmpstr, "; ");
            arcf_dstring_printf(afc->mctx_tmpstr, "arc=%s",
                                arc_chain_str(afc->mctx_arcmsg));
        }

For 'mode v' I see (openarc.c line 3636):

    if (BITSET(ARC_MODE_VERIFY, cc->cctx_mode))
    {
        /*
         **  Authentication-Results
        */

        arcf_dstring_blank(afc->mctx_tmpstr);
        arcf_dstring_printf(afc->mctx_tmpstr,
                            "%s%s; arc=%s",
                            cc->cctx_noleadspc ? " " : "",
                            conf->conf_authservid,
                            arc_chain_str(afc->mctx_arcmsg));
        if (arcf_insheader(ctx, 1, AUTHRESULTSHDR,
                           arcf_dstring_get(afc->mctx_tmpstr)) != MI_SUCCESS)
        {
            if (conf->conf_dolog)
            {
                syslog(LOG_ERR, "%s: %s header add failed",
                       afc->mctx_jobid, AUTHRESULTSHDR);
            }

            return SMFIS_TEMPFAIL;
        }
    }

Sorry, I'm not a programmer so please bear with me if this is a stupid question ;-)

The reason I ask is, that I get no 'Authentication-Results:' header when just using 'Mode v' (on an MTA that only handles inbound traffic), while I do get this header when changing mode to 'Mode sv'. See also my related message on the openarc-users list.

/rolf