[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lastest OpenARC commit


Hello Murray,

(may you consider to subscribe to openarc-dev@xxxxxxxxxxx ?)

the latest commit (https://github.com/mskucherawy/OpenARC/commit/b3faba121c07bce32d04895ee1c9f4278669a835)
generate some strange warning while building for OpenSUSE.

1. implicit-pointer-decl arc-util.c:557

I guess, that may be fixed by adding
	/* libbsd if found */
	#ifdef USE_BSD_H
	# include <bsd/string.h>
	#endif /* USE_BSD_H */
to libopenarc/arc-util.c

2. 64bit-portability-issue util.c:894

here I've no idea about the root cause. But I found comiler warnings for that file:

[   73s] gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I./../libopenarc  -I/usr/include -DCONFIG_BASE=\"/etc\" -pthread -DOPENSSL_LOAD_CONF  -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -fpie -fstack-protector -MT openarc-util.o -MD -MP -MF .deps/openarc-util.Tpo -c -o openarc-util.o `test -f 'util.c' || echo './'`util.c
[   73s] util.c: In function 'arcf_mkarray':
[   73s] util.c:894:2: warning: passing argument 2 of 'strtok' makes pointer from integer without a cast [enabled by default]
[   73s]   for (p = strtok(in, ','); *p != NULL; p = strtok(NULL, ','))
[   73s]   ^
[   73s] In file included from /usr/include/sys/un.h:37:0,
[   73s]                  from util.c:15:
[   73s] /usr/include/string.h:343:14: note: expected 'const char * restrict' but argument is of type 'int'
[   73s]  extern char *strtok (char *__restrict __s, const char *__restrict __delim)
[   73s]               ^
[   73s] util.c:894:31: warning: comparison between pointer and integer [enabled by default]
[   73s]   for (p = strtok(in, ','); *p != NULL; p = strtok(NULL, ','))
[   73s]                                ^
[   73s] util.c:894:2: warning: passing argument 2 of 'strtok' makes pointer from integer without a cast [enabled by default]
[   73s]   for (p = strtok(in, ','); *p != NULL; p = strtok(NULL, ','))
[   73s]   ^
[   73s] In file included from /usr/include/sys/un.h:37:0,
[   73s]                  from util.c:15:
[   73s] /usr/include/string.h:343:14: note: expected 'const char * restrict' but argument is of type 'int'
[   73s]  extern char *strtok (char *__restrict __s, const char *__restrict __delim)
[   73s]               ^
[   73s] util.c:896:5: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]
[   73s]   out[c] = NULL;

full buildlog: https://build.opensuse.org/package/live_build_log/home:andreasschulze/openarc/openSUSE_42.3/x86_64

Andreas